London | 25-SDC-Nov | Jesus del Moral | Sprint 5| Prep Exercises #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delmorallopez
force-pushed
the
Tools-Sprint5
branch
from
4cc7c30 to
294b028
Compare
delmorallopez
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 14, 2026
| # - Methods support inheritance | ||
| # - Better organization | ||
| # - Better organization | ||
| # - Methods enable polymorphism |
generics.py
Outdated
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Can this print grandchildren recursively?
Author
There was a problem hiding this comment.
I have made print_family_tree recursive, so it prints children, grandchildren, great-grandchildren...
There was a problem hiding this comment.
You might want to change the validation to allow for reentry if the input was invalid, rather than exiting immediately
Author
There was a problem hiding this comment.
I have modify the code, crating a while loop, each input is wrapped in a while True loop. Only break from the loop when a valid value is entered. Invalid entries print an error to stderr but don’t exit, so the user can retry.
LonMcGregor
added
Reviewed
delmorallopez
force-pushed
the
Tools-Sprint5
branch
from
01aed45 to
40a13c5
Compare
delmorallopez
added
the
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation exercise from Sprint5